import cleanup

.claude/rules/code-style.md

@@ -68,7 +68,10 @@ sub-modules can reach them via `use super::*`.
 ## Imports
 
 - Group imports: std, external crates, internal workspace crates, `crate::` imports
-- Use fully qualified paths for one-off references; `use` for repeated references
+- Prefer `use` imports over inline fully-qualified paths. Inline qualification is acceptable
+  only for genuine one-off references where adding an import would be noise, or for types
+  that collide with std prelude names (`Result`, `Option`, `Error`). If you reference a symbol
+  more than once, always import it.
 - Prefer specific imports over wildcards, except in `api_doc.rs` and test modules
 - When two crates export a type with the same name, alias with a suffix describing the source crate:
   `use enums::...::CommonResolution as CommonResolutionEnum;`

.claude/rules/testing.md

@@ -39,6 +39,14 @@ constants first, then tests, then helpers at the end of that sub-module.
 - Hash/deduplication functions with known inputs
 - Edge cases in parsers (empty input, missing fields, malformed data)
 
+## Imports in Tests
+
+- Import test fixtures and constants with `use`, not inline fully-qualified paths.
+  Write `use test_data::web::image_urls::JUNO_AT_LAKE_IMAGE_URL;` at the top,
+  then reference `JUNO_AT_LAKE_IMAGE_URL` in test bodies.
+- Same rule applies to enum variants used in match arms — import them, don't write
+  `crate::some::deep::module::MyEnum::Variant` inline.
+
 ## What Not to Test
 
 - Don't add integration tests that require a running database unless explicitly asked

CLAUDE.md

@@ -62,6 +62,7 @@ artcraft/
 - A mix of wreq and reqwest for Rust HTTP clients
 - Never use `println!` or `eprintln!` outside of tests; use `log` crate macros instead
 - When two crates export the same type name, alias imports with a suffix: `use foo::Bar as BarFoo;`
+- Prefer `use` imports over inline fully-qualified paths; only qualify inline for true one-offs or std collisions
 - TypeScript with Nx, React, Vite, Zustand, and Three.js
 - Use two spaces for indentation
 

crates/CLAUDE.md

@@ -10,6 +10,7 @@ All Rust code lives under `crates/`. The workspace is defined in `Cargo.toml` at
 - Use `anyhow::Result` / `AnyhowResult` for fallible functions in application code
 - Fields that are optional use the `maybe_` prefix: `maybe_creator_user_token`
 - When two crates export the same type name, alias with a suffix: `use foo::Bar as BarFoo;`
+- Prefer `use` imports over inline fully-qualified paths; only qualify inline for true one-offs or std prelude collisions (`Result`, `Option`, `Error`)
 
 ## File Layout
 

crates/api_clients/artcraft/artcraft_router/src/generate/generate_video_v2/providers/kinovi/seedance_2p0/cost.rs

@@ -83,6 +83,8 @@ mod tests {
   use crate::api::provider::Provider;
   use crate::api::video_list_ref::VideoListRef;
   use crate::generate::generate_video::generate_video_request_builder::GenerateVideoRequestBuilder;
+  use crate::generate::generate_video_v2::video_generation_draft::VideoGenerationDraftRequest;
+  use crate::generate::generate_video_v2::video_generation_draft_or_request::VideoGenerationDraftOrRequest;
 
   // ── 720p pricing ──
 
@@ -420,8 +422,8 @@ mod tests {
     };
 
     match builder.build2().expect("build2 should succeed") {
-      crate::generate::generate_video_v2::video_generation_draft_or_request::VideoGenerationDraftOrRequest::Draft(
-        crate::generate::generate_video_v2::video_generation_draft::VideoGenerationDraftRequest::KinoviSeedance2p0(draft)
+      VideoGenerationDraftOrRequest::Draft(
+        VideoGenerationDraftRequest::KinoviSeedance2p0(draft)
       ) => draft,
       _ => panic!("expected KinoviSeedance2p0 draft"),
     }

crates/api_clients/artcraft/artcraft_router/src/generate/generate_video_v2/providers/kinovi/seedance_2p0/request.rs

@@ -52,6 +52,7 @@ mod tests {
   use crate::generate::generate_video_v2::video_generation_draft_context::VideoGenerationDraftContext;
   use crate::generate::generate_video_v2::video_generation_draft_or_request::VideoGenerationDraftOrRequest;
   use seedance2pro_client::creds::seedance2pro_session::Seedance2ProSession;
+  use test_data::web::image_urls::{FOREST_BACKDROP_IMAGE_URL, JUNO_AT_LAKE_IMAGE_URL, WHITE_HOUSE_SUNSET_IMAGE_URL};
 
   const STEAMPUNK_CLOWN_KINOVI_ID: &str = "char_1775176566518_sik0te";
   const MOCHI_KINOVI_ID: &str = "char_1775177718294_g2pitx";
@@ -158,8 +159,8 @@ mod tests {
       let end_token = MediaFileToken::new("mf_end".to_string());
 
       let mut media_map = HashMap::new();
-      media_map.insert(start_token.clone(), test_data::web::image_urls::JUNO_AT_LAKE_IMAGE_URL.to_string());
-      media_map.insert(end_token.clone(), test_data::web::image_urls::FOREST_BACKDROP_IMAGE_URL.to_string());
+      media_map.insert(start_token.clone(), JUNO_AT_LAKE_IMAGE_URL.to_string());
+      media_map.insert(end_token.clone(), FOREST_BACKDROP_IMAGE_URL.to_string());
 
       let response = run_pipeline_with_media_map(GenerateVideoRequestBuilder {
         prompt: Some("The dog walks from the lake to the forest.".to_string()),
@@ -178,9 +179,9 @@ mod tests {
       let response = run_pipeline(GenerateVideoRequestBuilder {
         prompt: Some("The dog in @2 runs through the scenery in @1 towards the building in @3.".to_string()),
         reference_images: Some(ImageListRef::Urls(vec![
-          test_data::web::image_urls::FOREST_BACKDROP_IMAGE_URL.to_string(),
-          test_data::web::image_urls::JUNO_AT_LAKE_IMAGE_URL.to_string(),
-          test_data::web::image_urls::WHITE_HOUSE_SUNSET_IMAGE_URL.to_string(),
+          FOREST_BACKDROP_IMAGE_URL.to_string(),
+          JUNO_AT_LAKE_IMAGE_URL.to_string(),
+          WHITE_HOUSE_SUNSET_IMAGE_URL.to_string(),
         ])),
         aspect_ratio: Some(CommonAspectRatio::WideSixteenByNine),
         ..seedance2pro_builder()

crates/api_clients/artcraft/artcraft_router/src/generate/generate_video_v2/providers/kinovi/seedance_2p0_fast/cost.rs

@@ -84,6 +84,8 @@ mod tests {
   use crate::api::provider::Provider;
   use crate::api::video_list_ref::VideoListRef;
   use crate::generate::generate_video::generate_video_request_builder::GenerateVideoRequestBuilder;
+  use crate::generate::generate_video_v2::video_generation_draft::VideoGenerationDraftRequest;
+  use crate::generate::generate_video_v2::video_generation_draft_or_request::VideoGenerationDraftOrRequest;
 
   // ── Direct estimate_cost() tests ──
   // These must match the reference implementation values exactly.
@@ -372,8 +374,8 @@ mod tests {
     };
 
     match builder.build2().expect("build2 should succeed") {
-      crate::generate::generate_video_v2::video_generation_draft_or_request::VideoGenerationDraftOrRequest::Draft(
-        crate::generate::generate_video_v2::video_generation_draft::VideoGenerationDraftRequest::KinoviSeedance2p0Fast(draft)
+      VideoGenerationDraftOrRequest::Draft(
+        VideoGenerationDraftRequest::KinoviSeedance2p0Fast(draft)
       ) => draft,
       _ => panic!("expected KinoviSeedance2p0Fast draft"),
     }

crates/api_clients/artcraft/artcraft_router/src/generate/generate_video_v2/providers/kinovi/seedance_2p0_fast/request.rs

@@ -53,6 +53,7 @@ mod tests {
   use crate::generate::generate_video_v2::video_generation_draft_context::VideoGenerationDraftContext;
   use crate::generate::generate_video_v2::video_generation_draft_or_request::VideoGenerationDraftOrRequest;
   use seedance2pro_client::creds::seedance2pro_session::Seedance2ProSession;
+  use test_data::web::image_urls::{FOREST_BACKDROP_IMAGE_URL, JUNO_AT_LAKE_IMAGE_URL, WHITE_HOUSE_SUNSET_IMAGE_URL};
 
   mod aspect_ratio_tests {
     use super::*;
@@ -144,8 +145,8 @@ mod tests {
       let end_token = MediaFileToken::new("mf_end".to_string());
 
       let mut media_map = HashMap::new();
-      media_map.insert(start_token.clone(), test_data::web::image_urls::JUNO_AT_LAKE_IMAGE_URL.to_string());
-      media_map.insert(end_token.clone(), test_data::web::image_urls::FOREST_BACKDROP_IMAGE_URL.to_string());
+      media_map.insert(start_token.clone(), JUNO_AT_LAKE_IMAGE_URL.to_string());
+      media_map.insert(end_token.clone(), FOREST_BACKDROP_IMAGE_URL.to_string());
 
       let response = run_pipeline_with_media_map(GenerateVideoRequestBuilder {
         prompt: Some("The dog walks from the lake to the forest.".to_string()),
@@ -164,9 +165,9 @@ mod tests {
       let response = run_pipeline(GenerateVideoRequestBuilder {
         prompt: Some("The dog in @2 runs through the scenery in @1 towards the building in @3.".to_string()),
         reference_images: Some(ImageListRef::Urls(vec![
-          test_data::web::image_urls::FOREST_BACKDROP_IMAGE_URL.to_string(),
-          test_data::web::image_urls::JUNO_AT_LAKE_IMAGE_URL.to_string(),
-          test_data::web::image_urls::WHITE_HOUSE_SUNSET_IMAGE_URL.to_string(),
+          FOREST_BACKDROP_IMAGE_URL.to_string(),
+          JUNO_AT_LAKE_IMAGE_URL.to_string(),
+          WHITE_HOUSE_SUNSET_IMAGE_URL.to_string(),
         ])),
         aspect_ratio: Some(CommonAspectRatio::WideSixteenByNine),
         ..seedance2pro_fast_builder()