epicknex/multi
1
0
Fork 0
Code Issues 5 Pull Requests 1 Actions Packages Projects Releases 13 Wiki Activity

15.2.0 - Lanes has an issue where using join causes a hard crash #30

New Issue
Closed
opened 2021-12-17 23:38:22 -05:00 by rayaman · 7 comments
rayaman commented 2021-12-17 23:38:22 -05:00 (Migrated from github.com)
Copy Link
No description provided.
rayaman commented 2021-12-17 23:38:57 -05:00 (Migrated from github.com)
Copy Link

Issue fixed by using a pcall around the join call. Now it doesn't even error... How about that

Issue fixed by using a pcall around the join call. Now it doesn't even error... How about that
rayaman commented 2021-12-30 21:05:34 -05:00 (Migrated from github.com)
Copy Link

Not actually fixed

Not actually fixed
rayaman commented 2021-12-31 12:00:12 -05:00 (Migrated from github.com)
Copy Link

Seems like the issue is when the thread itself is cleaning up. Not the join call. Shortly after the thread ends Lua crashes. Not sure what is causing this. Will have to do more tests before filing an issue on the lualanes repo

Seems like the issue is when the thread itself is cleaning up. Not the join call. Shortly after the thread ends Lua crashes. Not sure what is causing this. Will have to do more tests before filing an issue on the lualanes repo
rayaman commented 2021-12-31 16:34:30 -05:00 (Migrated from github.com)
Copy Link

This isn't a good solution, but I decided to just make it so threads created using the multi library simply never end. Since the cancelation/termination of a lane seems to cause this error sometimes.

The sometimes is what gets me. What is going on with my system? Is this a configuration of my windows system that is causing this? Does this error happen on other OS's? So much testing has to be done.

This isn't a good solution, but I decided to just make it so threads created using the multi library simply never end. Since the cancelation/termination of a lane seems to cause this error sometimes. The sometimes is what gets me. What is going on with my system? Is this a configuration of my windows system that is causing this? Does this error happen on other OS's? So much testing has to be done.
rayaman commented 2022-01-01 11:05:18 -05:00 (Migrated from github.com)
Copy Link

So after some testing, the other lane may be touching data in the main thread causing issues

So after some testing, the other lane may be touching data in the main thread causing issues
rayaman commented 2022-01-01 13:49:01 -05:00 (Migrated from github.com)
Copy Link

This is probably not a lanes issue. When isolated lanes are created they terminate without issues. I'm not sure what is causing this to act like this. More testing needs to be done.

This is probably not a lanes issue. When isolated lanes are created they terminate without issues. I'm not sure what is causing this to act like this. More testing needs to be done.
rayaman commented 2022-01-02 11:47:49 -05:00 (Migrated from github.com)
Copy Link

So it might have been an issue with my drive. After changing drive labels I was unable to reproduce this issue. And I tried, I got so mad that I couldn't recreate the issue with the same code and the only thing that changed on my system is me changing my drive label since I was having problems deleting some files that were always in use for some reason. Now my code won't crash even though it has been completely reverted. Some of the optimizations I made in the process of trying to fix this will stay, but it's "Working now"

So it might have been an issue with my drive. After changing drive labels I was unable to reproduce this issue. And I tried, I got so mad that I couldn't recreate the issue with the same code and the only thing that changed on my system is me changing my drive label since I was having problems deleting some files that were always in use for some reason. Now my code won't crash even though it has been completely reverted. Some of the optimizations I made in the process of trying to fix this will stay, but it's "Working now"
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
Experimental Addition
help wanted
modification
New Version
P1
Critical Priority
P2
High Priority
P3
Normal Priority
P4
Low Priority
P5
Very Low Priority
Planned Removal
A feature that is being removed due to lack of use
question
Scheduled for future release
tests
Won't add
wontfix
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
epicknex
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: epicknex/multi#30
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?