diff --git a/hererocks.py b/hererocks.py index 328078a..7df7935 100755 --- a/hererocks.py +++ b/hererocks.py @@ -1437,7 +1437,7 @@ class RioLua(Lua): # from a git repo that does not have them, like the default one. if len(built_luac_objs) > 0: if using_cl(): - run("link", "/nologo", "/out:luac.exe", built_luac_objs, lib_objs) + run("link", "/nologo", "/out:luac.exe", built_luac_objs, [lib_obj for lib_obj in lib_objs if lib_obj != "lopcodes.obj"]) if os.path.exists("luac.exe.manifest"): run("mt", "/nologo", "-manifest", "luac.exe.manifest", "-outputresource:luac.exe") diff --git a/test/cli_test.py b/test/cli_test.py index 6e3803c..0a91fd0 100644 --- a/test/cli_test.py +++ b/test/cli_test.py @@ -150,3 +150,7 @@ class TestCLI(unittest.TestCase): def test_install_lua_5_4_with_luarocks_3(self): self.assertHererocksSuccess(["--lua", "5.4", "--luarocks", "3"]) self.assertHererocksSuccess(["--lua", "5.4.0-work1", "--luarocks", "3"]) + + if os.name == "nt": + self.assertHererocksSuccess(["--lua", "5.4", "--luarocks", "3", "--target", "vs"]) + self.assertHererocksSuccess(["--lua", "5.4.0-work1", "--luarocks", "3", "--target", "vs"])